Skip to content

!!! FEATURE: Refactor login form to Fusion#25

Closed
Sebobo wants to merge 2 commits into
Flowpack:masterfrom
Sebobo:feature/refactor-to-fusion
Closed

!!! FEATURE: Refactor login form to Fusion#25
Sebobo wants to merge 2 commits into
Flowpack:masterfrom
Sebobo:feature/refactor-to-fusion

Conversation

@Sebobo

@Sebobo Sebobo commented Dec 4, 2019

Copy link
Copy Markdown
Member

This replace the fluid part of the frontend login with Fusion Forms and AFX.

As this is a breaking change a new major release will be necessary.

@Sebobo Sebobo requested a review from mficzel December 4, 2019 08:41
@Sebobo

Sebobo commented Dec 4, 2019

Copy link
Copy Markdown
Member Author

@mficzel I have a problem with the field names here to make it work properly.

The necessary field name in the input has to be __authentication[Neos][Flow][Security][Authentication][Token][UsernamePassword][username]

But it's rendered as --flowpack_neos_frontendlogin-loginform[__authentication][Neos][Flow][Security][Authentication][Token][UsernamePassword][username]

Can you see what I do wrong?

@Sebobo

Sebobo commented Dec 4, 2019

Copy link
Copy Markdown
Member Author

Maybe we should make it possible to more easily replace the css classnames.
But would be great if someone else can look at that.
Also I made it possible to translate more parts of the login as some labels were static.

@Sebobo Sebobo requested a review from markusguenther December 4, 2019 08:47
@mficzel

mficzel commented Dec 5, 2019

Copy link
Copy Markdown
Member

@Sebobo i made a pr against this branch that goes a bit further and gets rid of this plugin mess since there is absolutely no need for that Sebobo#1

@mficzel mficzel force-pushed the feature/refactor-to-fusion branch from beabc4f to 03ca19f Compare December 6, 2019 09:25
@mficzel

mficzel commented Dec 6, 2019

Copy link
Copy Markdown
Member

I accidentally pushed my changes to your branch and had to force push the previous state. heere is the updated pr Sebobo#2

@mficzel mficzel mentioned this pull request Dec 6, 2019
@Sebobo

Sebobo commented Dec 7, 2019

Copy link
Copy Markdown
Member Author

Replaced by #26

@Sebobo Sebobo closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants